[netrek-dev] [PATCH] BRMH 2.5 segfault on pickled

[James Cameron]

The following patch should prevent BRMH 2.5 beta from generating a
segmentation fault on any server that has more features than the client
list.

--- brmh-dev-20071022.orig/feature.c	2007-10-09 02:32:24.000000000 +1000
+++ brmh-dev-20071022/feature.c	2008-07-24 10:04:24.000000000 +1000
@@ -140,8 +140,7 @@
    if (features[i].name == 0) {
       fprintf(stderr, "Feature %s from server unknown to client!\n", 
 	      packet->name);
-   }
-   if (!strcmp(features[i].name, "UPS"))
+   } else if (!strcmp(features[i].name, "UPS"))
    {
        cloak_phases = F_ups * 2 - 3;
        if (cloak_phases < 3)

-- 
James Cameron    mailto:quozl at us.netrek.org     http://quozl.netrek.org/