On Tue, 13 Jun 2006, Jimmy Huang wrote:

> --- Stephen Thorne <stephen.thorne at gmail.com> wrote:
> > Please unrecord and re-record this patch. Name the
> > patch slighty
> > differently, and resubmit. Thanks.
> Done. Removed the non-change.

How about actually going though the entire patch, and actually thinking
about each hunk?  When I look at the patch, I do this, why can't you do it

You have at least three completely different things being done in one patch,
and at least half a dozen hunks that are just random changes to unrelated code.

p_mapchars isn't a string, it's just two characters with no null termination.
You can't print it with %s.