On Wed, May 06, 2009 at 06:06:26PM +1000, James Cameron wrote: > The attached patch is the last of a series, this time to BRMH. Patch applied. Karthik, sorry to step on your toes. I've been using BRMH as my "get to know LP" subproject. You'll have it back by the time you sign up on LP. For those unaware, Karthik Arumugham is the current official BRMH maintainer. As part of the SF.net migration, the historical BRMH CVS repo has been imported to lp:netrek-archive/brmh. BRMH development on SF.net should be considered closed at this point. The following is subject to change as the LP project structure is being organized. I created a team branch at lp:~netrek-developers/netrek-client-brmh/brmh and linked in to a new brmh.dev series, which is the focus of development. You can checkout and push changes to this branch using lp:netrek-client-brmh. I have applied Karthik's 20071022, 20080725 BRMH 2.5 dev changes and James' client ID patch to the above brach as follows (summarized): bzr branch lp:netrek-archive/brmh untar BRMH-dev-20071022.tar.gz on top of brmh/ bzr commit untar BRMH-dev-20080725.tar.gz on top of brmh/ bzr commit patch -p1 < ../brmh-client-id.patch bzr commit bzr push lp:netrek-client-brmh So, the current lp:netrek-client-brmh should contain the latest BRMH 2.5.0 dev code with pending patches applied. Those who wish to work on the brmh.dev series should do something like the following: bzr branch lp:netrek-client-brmh <edit> bzr commit bzr push lp:netrek-client-brmh > > The previous patches were to netrek-server, netrek-client-cow, Netrek XP > 2009, and netrek-client-pygame. > > The patch uses the old feature support which sends client version, to > also send client name. > > The server did not use the version string for clients that have feature > packet support. The server now logs the version string. > > -- > James Cameron mailto:quozl at us.netrek.org http://quozl.netrek.org/ > --- brmh-dev-20071022.orig/feature_old.c 2000-01-14 06:56:55.000000000 +1100 > +++ brmh-dev-20071022/feature_old.c 2009-05-06 18:01:51.000000000 +1000 > @@ -54,10 +54,10 @@ > void > sendVersion() > { > - char client_ver[15]; > + char client_ver[80]; > if (!version_sent) { > version_sent = 1; > - sprintf(client_ver, "@%s.%d", VERSION, PATCHLEVEL); > + sprintf(client_ver, "@%s %s.%d", CLIENTNAME, VERSION, PATCHLEVEL); > > sendMessage(client_ver, MINDIV|MCONFIG, me->p_no); > } > --- brmh-dev-20071022.orig/version.h 2007-02-10 16:49:41.000000000 +1100 > +++ brmh-dev-20071022/version.h 2009-05-06 18:01:25.000000000 +1000 > @@ -8,6 +8,7 @@ > > #define PATCHLEVEL 0 > #define VERSION "2.5.0" > +#define CLIENTNAME "BRMH" > #define MAINTENANCE "karthik at karthik.com" > #define URL_NETREK "http://www.netrek.org/" > #define URL_XTREKRC "ftp://ftp.netrek.org/pub/netrek/clients/brmh/bin/BRMH-xtrekrc" > _______________________________________________ > netrek-dev mailing list > netrek-dev at us.netrek.org > http://mailman.us.netrek.org/mailman/listinfo/netrek-dev