Nice. For your interest, here's where the client code for SELF_8FLAGS2 gets it wrong; https://github.com/quozl/netrek-client-cow/blob/master/short.c#L496 Each of the bit shifts are reversed. I think it should be packet->pad1 & (PFTRACT >> 15)) << 15 Guess code was copied from a server implementation and only partly rewritten. Tedd Hadley and Heiko Wengler's amazing short packets code from 24th May 1993. ;-) On Thu, Mar 25, 2021 at 09:46:13PM -0700, Darrell Root wrote: > Thanks! I thought I was being lazy by skipping the short packets > implementation. But I was just forward-thinking! ;-). > > Related to SELF_8FLAGS2, I happen to be digging into Robert Temple’s old JTrek > client this evening and noticed that SELF_8FLAGS2 is turned off by default > there too. Of course that’s a client not a server. > > public class FeatureList { > … > public Feature[] features = { > ... > new Feature("SELF_8FLAGS2", Feature.SERVER_TYPE, Feature.OFF, > Feature.SEND_FEATURE), > > Darrell > > On Mar 25, 2021, at 9:35 PM, James Cameron <[1]quozl at laptop.org> wrote: > > Thanks. I'm glad. The complexity of short packets is no longer > justified; the internet has grown up. > > On Thu, Mar 25, 2021 at 05:37:23PM -0700, Darrell Root wrote: > > The Swift Netrek server does not implement short packets. So no impact > to my server. Thanks for asking! > > Darrell > > On Mar 25, 2021, at 4:46 PM, James Cameron <[2]quozl at laptop.org> > wrote: > > I was cleaning up compiler warnings in a client and found the > SELF_8FLAGS2 short packets feature that packs some of the me-> > p_flags > into a byte does actually misalign the flags beyond the 32-bit > width > of the target variable. > > There's no implementation of the feature in my server code. > > Does anyone know of a server side implementation of SELF_8FLAGS2? > > I'm inclined to remove it rather than fix it without testing it. > > -- > James Cameron > [3]https://quozl.linux.org.au/ > _______________________________________________ > netrek-dev mailing list > netrek-dev at us.netrek.org > http://mailman.us.netrek.org/mailman/listinfo/netrek-dev > > _______________________________________________ > netrek-dev mailing list > [4]netrek-dev at us.netrek.org > http://mailman.us.netrek.org/mailman/listinfo/netrek-dev > > -- > James Cameron > [5]https://quozl.linux.org.au/ > _______________________________________________ > netrek-dev mailing list > netrek-dev at us.netrek.org > http://mailman.us.netrek.org/mailman/listinfo/netrek-dev > > References: > > [1] mailto:quozl at laptop.org > [2] mailto:quozl at laptop.org > [3] https://quozl.linux.org.au/ > [4] mailto:netrek-dev at us.netrek.org > [5] https://quozl.linux.org.au/ > _______________________________________________ > netrek-dev mailing list > netrek-dev at us.netrek.org > http://mailman.us.netrek.org/mailman/listinfo/netrek-dev -- James Cameron https://quozl.linux.org.au/